E2E: per-test store isolation with robust teardown#7279
Draft
phyllis-sy-wu wants to merge 1 commit intopsyw-0413-E2E-temporary-time-limit-bumpfrom
Draft
E2E: per-test store isolation with robust teardown#7279phyllis-sy-wu wants to merge 1 commit intopsyw-0413-E2E-temporary-time-limit-bumpfrom
phyllis-sy-wu wants to merge 1 commit intopsyw-0413-E2E-temporary-time-limit-bumpfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
a47982f to
d6a4e19
Compare
4 tasks
d6a4e19 to
9659cf3
Compare
94f4908 to
d872975
Compare
9659cf3 to
2bb6ce4
Compare
4 tasks
2bb6ce4 to
e5289d3
Compare
e5289d3 to
5c0d260
Compare
77e5ea0 to
5765d59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
E2E tests currently share a single pre-existing dev store configured via
E2E_STORE_FQDN. This causes:teardownAppsilently skips steps, doesn't verify success, and a single failure blocks later cleanupThis PR also lays the foundation for parallel workers (future PR), where shared stores would be impossible since multiple tests run simultaneously.
WHAT is this pull request doing?
Per-test store isolation:
app dev,hot reload,multi-config dev,toml-config dev) create a fresh store via browser automation onadmin.shopify.com/store-create/organization/{orgId}Robust teardown with escalating retry (
setup/teardown.ts):pnpm test:e2e-cleanupTagged logging (
setup/env.ts):createLogger(tag)produces[e2e][w0][browser],[e2e][w0][cli]formate2eSection()prints section headers:----- SETUP: store ... -----,----- TEARDOWN: app ... -----Server error handling (
setup/browser.ts):refreshIfPageError(page)detects 500/502 error pages and auto-refreshesFiles changed:
setup/store.tsstoreTestFixture,isAppsPageEmpty()setup/teardown.tsteardownAll()with escalating retry + 90s timeoutsetup/app.tsfindAppOnDevDashboard()(with pagination),deleteAppFromDevDashboard(), remove oldteardownAppsetup/env.tscreateLogger(),e2eSection(),workerIndexsetup/cli.tssetup/browser.tsrefreshIfPageError()teardownAll, store-dependent tests usestoreTestFixtureHow to test your changes?
Checklist
pnpm changeset add